Unverified Commit 7c1dceaf authored by Pin-yen Lin's avatar Pin-yen Lin Committed by Robert Foss
Browse files

drm/bridge: it6505: Fix the order of DP_SET_POWER commands 



Send DP_SET_POWER_D3 command to the downstream before stopping DP, so the
suspend process will not be interrupted by the HPD interrupt. Also modify
the order in .atomic_enable callback to make the callbacks symmetric.

Fixes: 46ca7da7 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream")
Signed-off-by: default avatarPin-yen Lin <treapking@chromium.org>
Reviewed-by: default avatarRobert Foss <robert.foss@linaro.org>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220830045756.1655954-1-treapking@chromium.org
parent 1ff67333

drivers/gpu/drm/bridge/ite-it6505.c

+4 −4
Original line number Diff line number Diff line
@@ -2951,9 +2951,6 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge, 
	if (ret)

		dev_err(dev, "Failed to setup AVI infoframe: %d", ret);



	it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,

				     DP_SET_POWER_D0);



	it6505_update_video_parameter(it6505, mode);



	ret = it6505_send_video_infoframe(it6505, &frame);
@@ -2963,6 +2960,9 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge, 


	it6505_int_mask_enable(it6505);

	it6505_video_reset(it6505);



	it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,

				     DP_SET_POWER_D0);

}



static void it6505_bridge_atomic_disable(struct drm_bridge *bridge,
@@ -2974,9 +2974,9 @@ static void it6505_bridge_atomic_disable(struct drm_bridge *bridge, 
	DRM_DEV_DEBUG_DRIVER(dev, "start");



	if (it6505->powered) {

		it6505_video_disable(it6505);

		it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,

					     DP_SET_POWER_D3);

		it6505_video_disable(it6505);

	}

}