Commit 7c06458c authored by Laurent Vivier's avatar Laurent Vivier Committed by Jakub Kicinski
Browse files

virtio_net: disable VIRTIO_NET_F_STANDBY if VIRTIO_NET_F_MAC is not set 



failover relies on the MAC address to pair the primary and the standby
devices:

  "[...] the hypervisor needs to enable VIRTIO_NET_F_STANDBY
   feature on the virtio-net interface and assign the same MAC address
   to both virtio-net and VF interfaces."

  Documentation/networking/net_failover.rst

This patch disables the STANDBY feature if the MAC address is not
provided by the hypervisor.

Signed-off-by: default avatarLaurent Vivier <lvivier@redhat.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ca3daf43

drivers/net/virtio_net.c

+6 −0
Original line number Diff line number Diff line
@@ -3813,6 +3813,12 @@ static int virtnet_validate(struct virtio_device *vdev) 
			__virtio_clear_bit(vdev, VIRTIO_NET_F_MTU);

	}



	if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY) &&

	    !virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) {

		dev_warn(&vdev->dev, "device advertises feature VIRTIO_NET_F_STANDBY but not VIRTIO_NET_F_MAC, disabling standby");

		__virtio_clear_bit(vdev, VIRTIO_NET_F_STANDBY);

	}



	return 0;

}