Commit 7bc416f1 authored by Lukas Bulwahn's avatar Lukas Bulwahn Committed by Pablo Neira Ayuso
Browse files

netfilter: x_tables: handle xt_register_template() returning an error value 



Commit fdacd57c ("netfilter: x_tables: never register tables by
default") introduces the function xt_register_template(), and in one case,
a call to that function was missing the error-case handling.

Handle when xt_register_template() returns an error value.

This was identified with the clang-analyzer's Dead-Store analysis.

Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 6c89dac5

net/ipv4/netfilter/iptable_mangle.c

+2 −0
Original line number Diff line number Diff line
@@ -112,6 +112,8 @@ static int __init iptable_mangle_init(void) 
{

	int ret = xt_register_template(&packet_mangler,

				       iptable_mangle_table_init);

	if (ret < 0)

		return ret;



	mangle_ops = xt_hook_ops_alloc(&packet_mangler, iptable_mangle_hook);

	if (IS_ERR(mangle_ops)) {