Commit 7ba85fba authored by Dave Chinner's avatar Dave Chinner Committed by Darrick J. Wong
Browse files

fork: remove use of percpu_counter_sum_all 



This effectively reverts the change made in commit f689054a
("percpu_counter: add percpu_counter_sum_all interface") as the
race condition percpu_counter_sum_all() was invented to avoid is
now handled directly in percpu_counter_sum() and nobody needs to
care about summing racing with cpu unplug anymore.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
parent 8b57b11c

kernel/fork.c

+0 −5
Original line number Diff line number Diff line
@@ -755,11 +755,6 @@ static void check_mm(struct mm_struct *mm) 
	for (i = 0; i < NR_MM_COUNTERS; i++) {

		long x = percpu_counter_sum(&mm->rss_stat[i]);



		if (likely(!x))

			continue;



		/* Making sure this is not due to race with CPU offlining. */

		x = percpu_counter_sum_all(&mm->rss_stat[i]);

		if (unlikely(x))

			pr_alert("BUG: Bad rss-counter state mm:%p type:%s val:%ld\n",

				 mm, resident_page_types[i], x);