Commit 7b8ce1f2 authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Mauro Carvalho Chehab
Browse files

media: staging: rkisp1: rsz: supported formats are the isp's src formats, not sink formats 



The rkisp1_resizer's enum callback 'rkisp1_rsz_enum_mbus_code'
calls the enum callback of the 'rkisp1_isp' on it's video sink pad.
This is a bug, the resizer should support the same formats
supported by the 'rkisp1_isp' on the source pad (not the sink pad).

Fixes: 56e3b29f "media: staging: rkisp1: add streaming paths"
Signed-off-by: default avatarDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: default avatarHelen Koike <helen.koike@collabora.com>
Reviewed-by: default avatarTomasz Figa <tfiga@chromium.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d93d45ab

drivers/staging/media/rkisp1/rkisp1-resizer.c

+2 −2
Original line number Diff line number Diff line
@@ -437,8 +437,8 @@ static int rkisp1_rsz_enum_mbus_code(struct v4l2_subdev *sd, 
	u32 pad = code->pad;

	int ret;



	/* supported mbus codes are the same in isp sink pad */

	code->pad = RKISP1_ISP_PAD_SINK_VIDEO;

	/* supported mbus codes are the same in isp video src pad */

	code->pad = RKISP1_ISP_PAD_SOURCE_VIDEO;

	ret = v4l2_subdev_call(&rsz->rkisp1->isp.sd, pad, enum_mbus_code,

			       &dummy_cfg, code);