Commit 7b87ddc0 authored by Rob Herring's avatar Rob Herring Committed by Lorenzo Pieralisi
Browse files

PCI: dwc/qcom: Use common PCI register definitions 

The QCom driver has its own defines for common PCI config space
registers. It also hard codes the capability register offsets which are
discoverable. Convert it to use the standard register definitions.

Link: https://lore.kernel.org/r/20200821035420.380495-30-robh@kernel.org


Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-arm-msm@vger.kernel.org
parent 201a8df8

drivers/pci/controller/dwc/pcie-qcom.c

+8 −10
Original line number Diff line number Diff line
@@ -67,10 +67,6 @@ 
#define PCIE20_AXI_MSTR_RESP_COMP_CTRL1		0x81c

#define CFG_BRIDGE_SB_INIT			BIT(0)



#define PCIE20_CAP				0x70

#define PCIE20_DEVICE_CONTROL2_STATUS2		(PCIE20_CAP + PCI_EXP_DEVCTL2)

#define PCIE20_CAP_LINK_CAPABILITIES		(PCIE20_CAP + PCI_EXP_LNKCAP)

#define PCIE20_CAP_LINK_1			(PCIE20_CAP + 0x14)

#define PCIE_CAP_LINK1_VAL			0x2FD7F



#define PCIE20_PARF_Q2A_FLUSH			0x1AC
@@ -1017,6 +1013,7 @@ static int qcom_pcie_init_2_3_3(struct qcom_pcie *pcie) 
	struct qcom_pcie_resources_2_3_3 *res = &pcie->res.v2_3_3;

	struct dw_pcie *pci = pcie->pci;

	struct device *dev = pci->dev;

	u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);

	int i, ret;

	u32 val;
@@ -1092,14 +1089,14 @@ static int qcom_pcie_init_2_3_3(struct qcom_pcie *pcie) 


	writel(PCI_COMMAND_MASTER, pci->dbi_base + PCI_COMMAND);

	writel(DBI_RO_WR_EN, pci->dbi_base + PCIE20_MISC_CONTROL_1_REG);

	writel(PCIE_CAP_LINK1_VAL, pci->dbi_base + PCIE20_CAP_LINK_1);

	writel(PCIE_CAP_LINK1_VAL, pci->dbi_base + offset + PCI_EXP_SLTCAP);



	val = readl(pci->dbi_base + PCIE20_CAP_LINK_CAPABILITIES);

	val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP);

	val &= ~PCI_EXP_LNKCAP_ASPMS;

	writel(val, pci->dbi_base + PCIE20_CAP_LINK_CAPABILITIES);

	writel(val, pci->dbi_base + offset + PCI_EXP_LNKCAP);



	writel(PCI_EXP_DEVCTL2_COMP_TMOUT_DIS, pci->dbi_base +

		PCIE20_DEVICE_CONTROL2_STATUS2);

	writel(PCI_EXP_DEVCTL2_COMP_TMOUT_DIS, pci->dbi_base + offset +

		PCI_EXP_DEVCTL2);



	return 0;
@@ -1252,7 +1249,8 @@ static void qcom_pcie_post_deinit_2_7_0(struct qcom_pcie *pcie) 


static int qcom_pcie_link_up(struct dw_pcie *pci)

{

	u16 val = readw(pci->dbi_base + PCIE20_CAP + PCI_EXP_LNKSTA);

	u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);

	u16 val = readw(pci->dbi_base + offset + PCI_EXP_LNKSTA);



	return !!(val & PCI_EXP_LNKSTA_DLLLA);

}