Commit 7b8232bd authored by Qiheng Lin's avatar Qiheng Lin Committed by Paolo Abeni
Browse files

net: microchip: sparx5: Fix missing destroy_workqueue of mact_queue 



The mchp_sparx5_probe() won't destroy workqueue created by
create_singlethread_workqueue() in sparx5_start() when later
inits failed. Add destroy_workqueue in the cleanup_ports case,
also add it in mchp_sparx5_remove()

Fixes: b37a1bae ("net: sparx5: add mactable support")
Signed-off-by: default avatarQiheng Lin <linqiheng@huawei.com>
Link: https://lore.kernel.org/r/20221203070259.19560-1-linqiheng@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ee496694

drivers/net/ethernet/microchip/sparx5/sparx5_main.c

+3 −0
Original line number Diff line number Diff line
@@ -887,6 +887,8 @@ static int mchp_sparx5_probe(struct platform_device *pdev) 


cleanup_ports:

	sparx5_cleanup_ports(sparx5);

	if (sparx5->mact_queue)

		destroy_workqueue(sparx5->mact_queue);

cleanup_config:

	kfree(configs);

cleanup_pnode:
@@ -911,6 +913,7 @@ static int mchp_sparx5_remove(struct platform_device *pdev) 
	sparx5_cleanup_ports(sparx5);

	/* Unregister netdevs */

	sparx5_unregister_notifier_blocks(sparx5);

	destroy_workqueue(sparx5->mact_queue);



	return 0;

}