Commit 7b5add9a authored by Dan Carpenter's avatar Dan Carpenter Committed by Paolo Abeni
Browse files

ixgbe: fix crash with empty VF macvlan list 



The adapter->vf_mvs.l list needs to be initialized even if the list is
empty.  Otherwise it will lead to crashes.

Fixes: a1cbb15c ("ixgbe: Add macvlan support for VF")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Link: https://lore.kernel.org/r/ZSADNdIw8zFx1xw2@kadam


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 1b9d8bc1

drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c

+3 −2
Original line number Diff line number Diff line
@@ -28,6 +28,9 @@ static inline void ixgbe_alloc_vf_macvlans(struct ixgbe_adapter *adapter, 
	struct vf_macvlans *mv_list;

	int num_vf_macvlans, i;



	/* Initialize list of VF macvlans */

	INIT_LIST_HEAD(&adapter->vf_mvs.l);



	num_vf_macvlans = hw->mac.num_rar_entries -

			  (IXGBE_MAX_PF_MACVLANS + 1 + num_vfs);

	if (!num_vf_macvlans)
@@ -36,8 +39,6 @@ static inline void ixgbe_alloc_vf_macvlans(struct ixgbe_adapter *adapter, 
	mv_list = kcalloc(num_vf_macvlans, sizeof(struct vf_macvlans),

			  GFP_KERNEL);

	if (mv_list) {

		/* Initialize list of VF macvlans */

		INIT_LIST_HEAD(&adapter->vf_mvs.l);

		for (i = 0; i < num_vf_macvlans; i++) {

			mv_list[i].vf = -1;

			mv_list[i].free = true;