Commit 7b511616 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

firmware: raspberrypi: fix possible memory leak in rpi_firmware_probe() 



In rpi_firmware_probe(), if mbox_request_channel() fails, the 'fw' will
not be freed through rpi_firmware_delete(), fix this leak by calling
kfree() in the error path.

Fixes: 1e7c5735 ("firmware: raspberrypi: Keep count of all consumers")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221117070636.3849773-1-yangyingliang@huawei.com


Acked-by: default avatarJoel Savitz <jsavitz@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3127a86a

drivers/firmware/raspberrypi.c

+1 −0
Original line number Diff line number Diff line
@@ -272,6 +272,7 @@ static int rpi_firmware_probe(struct platform_device *pdev) 
		int ret = PTR_ERR(fw->chan);

		if (ret != -EPROBE_DEFER)

			dev_err(dev, "Failed to get mbox channel: %d\n", ret);

		kfree(fw);

		return ret;

	}