Commit 7adde5ac authored by Yuan Can's avatar Yuan Can Committed by Miquel Raynal
Browse files

mtd: parsers: Fix potential memory leak in mtd_parser_tplink_safeloader_parse() 



The parts needs to be freed with all its elements, otherwise it will be
leaked.

Fixes: 00a35880 ("mtd: parsers: add TP-Link SafeLoader partitions table parser")
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Reviewed-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20221208113620.78855-1-yuancan@huawei.com
parent 88603b6d

drivers/mtd/parsers/tplink_safeloader.c

+3 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd, 
	buf = mtd_parser_tplink_safeloader_read_table(mtd);

	if (!buf) {

		err = -ENOENT;

		goto err_out;

		goto err_free_parts;

	}



	for (idx = 0, offset = TPLINK_SAFELOADER_DATA_OFFSET;
@@ -118,6 +118,8 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd, 
err_free:

	for (idx -= 1; idx >= 0; idx--)

		kfree(parts[idx].name);

err_free_parts:

	kfree(parts);

err_out:

	return err;

};