Commit 7ad697cd authored by Bryan Tan's avatar Bryan Tan Committed by Jason Gunthorpe
Browse files

RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode 

wr->opcode is unsigned; checking if it is negative is unnecessary. Fix
this issue by removing the check.

Fixes: 29c8d9eb ("IB: Add vmw_pvrdma driver")
Link: https://lore.kernel.org/r/20230605183728.47021-1-bryantan@vmware.com


Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/07c48eee-0aca-48ee-897a-38588c341c41@kili.mountain


Signed-off-by: default avatarBryan Tan <bryantan@vmware.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent c3e1bf62

drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c

+0 −8
Original line number Diff line number Diff line
@@ -709,14 +709,6 @@ int pvrdma_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr, 
			goto out;

		}



		if (unlikely(wr->opcode < 0)) {

			dev_warn_ratelimited(&dev->pdev->dev,

					     "invalid send opcode\n");

			*bad_wr = wr;

			ret = -EINVAL;

			goto out;

		}



		/*

		 * Only support UD, RC.

		 * Need to check opcode table for thorough checking.