Commit 7ab89db9 authored Apr 23, 2022 by Michal Orzel Committed by Jens Axboe Apr 23, 2022

block/blk-map: Remove redundant assignment



Get rid of redundant assignment to a variable ret from function
bio_map_user_iov as it is being assigned a value that is never read.
It is being re-assigned in the first instruction after the while loop

Reported by clang-tidy [deadcode.DeadStores]

Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Link: https://lore.kernel.org/r/20220423113811.13335-2-michalorzel.eng@gmail.com


Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 3de2e5f2

block/blk-map.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -262,10 +262,9 @@ static int bio_map_user_iov(struct request rq, struct iov_iter iter,

		npages = DIV_ROUND_UP(offs + bytes, PAGE_SIZE);

		if (unlikely(offs & queue_dma_alignment(rq->q))) {
		ret = -EINVAL;
		if (unlikely(offs & queue_dma_alignment(rq->q)))
		j = 0;
		} else {
		else {
		for (j = 0; j < npages; j++) {
		struct page *page = pages[j];
		unsigned int n = PAGE_SIZE - offs;