Commit 7ab1a491 authored by Mario Limonciello's avatar Mario Limonciello Committed by Alex Deucher
Browse files

drm/amd: Tighten permissions on VBIOS flashing attributes 



Non-root users shouldn't be able to try to trigger a VBIOS flash
or query the flashing status.  This should be reserved for users with the
appropriate permissions.

Cc: stable@vger.kernel.org
Fixes: 8424f2cc ("drm/amdgpu/psp: Add vbflash sysfs interface support")
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 3eb1a3a0

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

+2 −2
Original line number Diff line number Diff line
@@ -3602,13 +3602,13 @@ static ssize_t amdgpu_psp_vbflash_status(struct device *dev, 
}



static const struct bin_attribute psp_vbflash_bin_attr = {

	.attr = {.name = "psp_vbflash", .mode = 0664},

	.attr = {.name = "psp_vbflash", .mode = 0660},

	.size = 0,

	.write = amdgpu_psp_vbflash_write,

	.read = amdgpu_psp_vbflash_read,

};



static DEVICE_ATTR(psp_vbflash_status, 0444, amdgpu_psp_vbflash_status, NULL);

static DEVICE_ATTR(psp_vbflash_status, 0440, amdgpu_psp_vbflash_status, NULL);



int amdgpu_psp_sysfs_init(struct amdgpu_device *adev)

{