Commit 7a9795b3 authored by Yang Yingliang's avatar Yang Yingliang Committed by Mauro Carvalho Chehab
Browse files

media: ov7251: add missing disable functions on error in ov7251_set_power_on() 



Add the missing gpiod_set_value_cansleep() and clk_disable_unprepare()
before return from ov7251_set_power_on() in the error handling case.

Fixes: 9e1d3012 ("media: i2c: Remove .s_power() from ov7251")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 94d7fd96

drivers/media/i2c/ov7251.c

+2 −0
Original line number Diff line number Diff line
@@ -934,6 +934,8 @@ static int ov7251_set_power_on(struct device *dev) 
					ARRAY_SIZE(ov7251_global_init_setting));

	if (ret < 0) {

		dev_err(ov7251->dev, "error during global init\n");

		gpiod_set_value_cansleep(ov7251->enable_gpio, 0);

		clk_disable_unprepare(ov7251->xclk);

		ov7251_regulators_disable(ov7251);

		return ret;

	}