Commit 7a9213a9 authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s 



A few BUG_ON()'s in replace_path are purely to keep us from making
logical mistakes, so replace them with ASSERT()'s.

Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 592fbcd5

fs/btrfs/relocation.c

+3 −3
Original line number Diff line number Diff line
@@ -1211,8 +1211,8 @@ int replace_path(struct btrfs_trans_handle *trans, struct reloc_control *rc, 
	int ret;

	int slot;



	BUG_ON(src->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID);

	BUG_ON(dest->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID);

	ASSERT(src->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID);

	ASSERT(dest->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID);



	last_snapshot = btrfs_root_last_snapshot(&src->root_item);

again:
@@ -1243,7 +1243,7 @@ int replace_path(struct btrfs_trans_handle *trans, struct reloc_control *rc, 
	parent = eb;

	while (1) {

		level = btrfs_header_level(parent);

		BUG_ON(level < lowest_level);

		ASSERT(level >= lowest_level);



		ret = btrfs_bin_search(parent, &key, &slot);

		if (ret < 0)