Commit 7a7f5857 authored by Pierre Gondois's avatar Pierre Gondois Committed by Rob Herring
Browse files

of: base: Shift refcount decrement in of_find_last_cache_level() 



Currently, of_find_next_cache_node() and of_property_read_u32()
are called on objects after their refcount have been decremented.
Re-order the calls to decrement the refcount after the function
calls.

Signed-off-by: default avatarPierre Gondois <pierre.gondois@arm.com>
Link: https://lore.kernel.org/r/20220930144936.2882481-1-pierre.gondois@arm.com


Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent abb1bc7e

drivers/of/base.c

+2 −1
Original line number Diff line number Diff line
@@ -2088,12 +2088,13 @@ int of_find_last_cache_level(unsigned int cpu) 
	struct device_node *prev = NULL, *np = of_cpu_device_node_get(cpu);



	while (np) {

		of_node_put(prev);

		prev = np;

		of_node_put(np);

		np = of_find_next_cache_node(np);

	}



	of_property_read_u32(prev, "cache-level", &cache_level);

	of_node_put(prev);



	return cache_level;

}