Unverified Commit 7a653169 authored Jun 29, 2023 by Krzysztof Wilczyński

PCI: keembay: Remove cast between incompatible function type

Rather than casting void(*)(struct clk *) to void (*)(void *), that
forces conversion to an incompatible function type, replace the cast
with a small local stub function with a signature that matches what
the devm_add_action_or_reset() function expects.

The sub function takes a void *, then passes it directly to
clk_disable_unprepare(), which handles the more specific type.

Reported by clang when building with warnings enabled:

  drivers/pci/controller/dwc/pcie-keembay.c:172:12: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
                                         (void(*)(void *))clk_disable_unprepare,
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
No functional changes are intended.

Fixes: 0c87f90b ("PCI: keembay: Add support for Intel Keem Bay")
Link: https://lore.kernel.org/linux-pci/20230629165956.237832-2-kwilczynski@kernel.org


Acked-by: Srikanth Thokala <srikanth.thokala@intel.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

parent 1a8bf351

drivers/pci/controller/dwc/pcie-keembay.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -148,6 +148,13 @@ static const struct dw_pcie_ops keembay_pcie_ops = {
		.stop_link = keembay_pcie_stop_link,
		};

		static inline void keembay_pcie_disable_clock(void *data)
		{
		struct clk *clk = data;

		clk_disable_unprepare(clk);
		}

		static inline struct clk keembay_pcie_probe_clock(struct device dev,
		const char *id, u64 rate)
		{
		@@ -168,9 +175,7 @@ static inline struct clk keembay_pcie_probe_clock(struct device dev,
		if (ret)
		return ERR_PTR(ret);

		ret = devm_add_action_or_reset(dev,
		(void()(void ))clk_disable_unprepare,
		clk);
		ret = devm_add_action_or_reset(dev, keembay_pcie_disable_clock, clk);
		if (ret)
		return ERR_PTR(ret);