Commit 7a038a68 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: gadget: pxa25x_udc: fix memory leak with using debugfs_lookup() 

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Link: https://lore.kernel.org/r/20230202153235.2412790-11-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e3965aca

drivers/usb/gadget/udc/pxa25x_udc.c

+1 −1
Original line number Diff line number Diff line
@@ -1340,7 +1340,7 @@ DEFINE_SHOW_ATTRIBUTE(udc_debug); 
		debugfs_create_file(dev->gadget.name, \

			S_IRUGO, NULL, dev, &udc_debug_fops); \

	} while (0)

#define remove_debug_files(dev) debugfs_remove(debugfs_lookup(dev->gadget.name, NULL))

#define remove_debug_files(dev) debugfs_lookup_and_remove(dev->gadget.name, NULL)



#else	/* !CONFIG_USB_GADGET_DEBUG_FILES */