Commit 79da290e authored by Mario Limonciello's avatar Mario Limonciello Committed by Alex Deucher
Browse files

drm/amd: Use `amdgpu_ucode_release` helper for si 



The `amdgpu_ucode_release` helper is replacing all calls
to release_firmware.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 778af666

drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c

+2 −9
Original line number Diff line number Diff line
@@ -7714,20 +7714,13 @@ static int si_dpm_init_microcode(struct amdgpu_device *adev) 
	}



	snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_smc.bin", chip_name);

	err = request_firmware(&adev->pm.fw, fw_name, adev->dev);

	if (err)

		goto out;

	err = amdgpu_ucode_validate(adev->pm.fw);



out:

	err = amdgpu_ucode_request(adev, &adev->pm.fw, fw_name);

	if (err) {

		DRM_ERROR("si_smc: Failed to load firmware. err = %d\"%s\"\n",

			  err, fw_name);

		release_firmware(adev->pm.fw);

		adev->pm.fw = NULL;

		amdgpu_ucode_release(&adev->pm.fw);

	}

	return err;



}



static int si_dpm_sw_init(void *handle)