Commit 79c932cd authored by Daniel Wagner's avatar Daniel Wagner Committed by Martin K. Petersen
Browse files

scsi: qedf: Do not put host in qedf_vport_create() unconditionally 

Do not drop reference count on vn_port->host in qedf_vport_create()
unconditionally. Instead drop the reference count in qedf_vport_destroy().

Link: https://lore.kernel.org/r/20210521143440.84816-1-dwagner@suse.de


Reported-by: default avatarJaved Hasan <jhasan@marvell.com>
Signed-off-by: default avatarDaniel Wagner <dwagner@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 696770e7

drivers/scsi/qedf/qedf_main.c

+9 −11
Original line number Diff line number Diff line
@@ -1827,22 +1827,20 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) 
		fcoe_wwn_to_str(vport->port_name, buf, sizeof(buf));

		QEDF_WARN(&(base_qedf->dbg_ctx), "Failed to create vport, "

			   "WWPN (0x%s) already exists.\n", buf);

		goto err1;

		return rc;

	}



	if (atomic_read(&base_qedf->link_state) != QEDF_LINK_UP) {

		QEDF_WARN(&(base_qedf->dbg_ctx), "Cannot create vport "

			   "because link is not up.\n");

		rc = -EIO;

		goto err1;

		return -EIO;

	}



	vn_port = libfc_vport_create(vport, sizeof(struct qedf_ctx));

	if (!vn_port) {

		QEDF_WARN(&(base_qedf->dbg_ctx), "Could not create lport "

			   "for vport.\n");

		rc = -ENOMEM;

		goto err1;

		return -ENOMEM;

	}



	fcoe_wwn_to_str(vport->port_name, buf, sizeof(buf));
@@ -1866,7 +1864,7 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) 
	if (rc) {

		QEDF_ERR(&(base_qedf->dbg_ctx), "Could not allocate memory "

		    "for lport stats.\n");

		goto err2;

		goto err;

	}



	fc_set_wwnn(vn_port, vport->node_name);
@@ -1884,7 +1882,7 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) 
	if (rc) {

		QEDF_WARN(&base_qedf->dbg_ctx,

			  "Error adding Scsi_Host rc=0x%x.\n", rc);

		goto err2;

		goto err;

	}



	/* Set default dev_loss_tmo based on module parameter */
@@ -1925,9 +1923,10 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled) 
	vport_qedf->dbg_ctx.host_no = vn_port->host->host_no;

	vport_qedf->dbg_ctx.pdev = base_qedf->pdev;



err2:

	return 0;



err:

	scsi_host_put(vn_port->host);

err1:

	return rc;

}
@@ -1968,7 +1967,6 @@ static int qedf_vport_destroy(struct fc_vport *vport) 
	fc_lport_free_stats(vn_port);



	/* Release Scsi_Host */

	if (vn_port->host)

	scsi_host_put(vn_port->host);



out: