Commit 7968c7c7 authored by Zhang Qilong's avatar Zhang Qilong Committed by Marc Kleine-Budde
Browse files

can: ti_hecc: Fix memleak in ti_hecc_probe 



In the error handling, we should goto the probe_exit_candev
to free ndev to prevent memory leak.

Fixes: dabf54dd ("can: ti_hecc: Convert TI HECC driver to DT only driver")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201114111708.3465543-1-zhangqilong3@huawei.com


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent a1e65407

drivers/net/can/ti_hecc.c

+8 −5
Original line number Diff line number Diff line
@@ -881,7 +881,8 @@ static int ti_hecc_probe(struct platform_device *pdev) 
	priv->base = devm_platform_ioremap_resource_byname(pdev, "hecc");

	if (IS_ERR(priv->base)) {

		dev_err(&pdev->dev, "hecc ioremap failed\n");

		return PTR_ERR(priv->base);

		err = PTR_ERR(priv->base);

		goto probe_exit_candev;

	}



	/* handle hecc-ram memory */
@@ -889,20 +890,22 @@ static int ti_hecc_probe(struct platform_device *pdev) 
							       "hecc-ram");

	if (IS_ERR(priv->hecc_ram)) {

		dev_err(&pdev->dev, "hecc-ram ioremap failed\n");

		return PTR_ERR(priv->hecc_ram);

		err = PTR_ERR(priv->hecc_ram);

		goto probe_exit_candev;

	}



	/* handle mbx memory */

	priv->mbx = devm_platform_ioremap_resource_byname(pdev, "mbx");

	if (IS_ERR(priv->mbx)) {

		dev_err(&pdev->dev, "mbx ioremap failed\n");

		return PTR_ERR(priv->mbx);

		err = PTR_ERR(priv->mbx);

		goto probe_exit_candev;

	}



	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);

	if (!irq) {

		dev_err(&pdev->dev, "No irq resource\n");

		goto probe_exit;

		goto probe_exit_candev;

	}



	priv->ndev = ndev;
@@ -966,7 +969,7 @@ static int ti_hecc_probe(struct platform_device *pdev) 
	clk_put(priv->clk);

probe_exit_candev:

	free_candev(ndev);

probe_exit:



	return err;

}