Unverified Commit 7964e817 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Mark Brown
Browse files

spi: microchip-core: Simplify some error message 



dev_err_probe() already prints the error code in a human readable way, so
there is no need to duplicate it as a numerical value at the end of the
message.

Moreover, in the case of devm_clk_get() it would only display '0' because
'ret' is know to be 0 at this point.

Fixes: cdeaf3a9 ("spi: microchip-core: switch to use dev_err_probe()")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/fb894ecec68e03fb7fc9353027c8b1a2610833d7.1659735153.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent dad57a51

drivers/spi/spi-microchip-core.c

+2 −2
Original line number Diff line number Diff line
@@ -548,12 +548,12 @@ static int mchp_corespi_probe(struct platform_device *pdev) 
			       IRQF_SHARED, dev_name(&pdev->dev), master);

	if (ret)

		return dev_err_probe(&pdev->dev, ret,

				     "could not request irq: %d\n", ret);

				     "could not request irq\n");



	spi->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(spi->clk))

		return dev_err_probe(&pdev->dev, PTR_ERR(spi->clk),

				     "could not get clk: %d\n", ret);

				     "could not get clk\n");



	ret = clk_prepare_enable(spi->clk);

	if (ret)