Commit 7962893e authored by Imre Deak's avatar Imre Deak
Browse files

drm/i915: Disable runtime power management during shutdown 



At least on some TGL platforms PUNIT wants to access some display HW
registers, but it doesn't handle display power management (disabling DC
states as required) and so this register access will lead to a hang. To
prevent this disable runtime power management for poweroff and reboot.

v2:
- Add code comment clarifying the requirement of display power states.
  (Ville)

Reported-and-tested-by: default avatarKhaled Almahallawy <khaled.almahallawy@intel.com>
Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Reviewed-by: default avatarKhaled Almahallawy <khaled.almahallawy@intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210127181909.128094-1-imre.deak@intel.com
parent 58a92bce

drivers/gpu/drm/i915/i915_drv.c

+10 −0
Original line number Diff line number Diff line
@@ -1047,6 +1047,8 @@ static void intel_shutdown_encoders(struct drm_i915_private *dev_priv) 
void i915_driver_shutdown(struct drm_i915_private *i915)

{

	disable_rpm_wakeref_asserts(&i915->runtime_pm);

	intel_runtime_pm_disable(&i915->runtime_pm);

	intel_power_domains_disable(i915);



	i915_gem_suspend(i915);
@@ -1062,7 +1064,15 @@ void i915_driver_shutdown(struct drm_i915_private *i915) 
	intel_suspend_encoders(i915);

	intel_shutdown_encoders(i915);



	/*

	 * The only requirement is to reboot with display DC states disabled,

	 * for now leaving all display power wells in the INIT power domain

	 * enabled matching the driver reload sequence.

	 */

	intel_power_domains_driver_remove(i915);

	enable_rpm_wakeref_asserts(&i915->runtime_pm);



	intel_runtime_pm_driver_release(&i915->runtime_pm);

}



static bool suspend_to_idle(struct drm_i915_private *dev_priv)