Commit 795e3d2e authored by Harshvardhan Jha's avatar Harshvardhan Jha Committed by David S. Miller
Browse files

net: qede: Fix end of loop tests for list_for_each_entry 



The list_for_each_entry() iterator, "vlan" in this code, can never be
NULL so the warning will never be printed.

Signed-off-by: default avatarHarshvardhan Jha <harshvardhan.jha@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7e4960b3

drivers/net/ethernet/qlogic/qede/qede_filter.c

+2 −2
Original line number Diff line number Diff line
@@ -831,7 +831,7 @@ int qede_configure_vlan_filters(struct qede_dev *edev) 
int qede_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)

{

	struct qede_dev *edev = netdev_priv(dev);

	struct qede_vlan *vlan = NULL;

	struct qede_vlan *vlan;

	int rc = 0;



	DP_VERBOSE(edev, NETIF_MSG_IFDOWN, "Removing vlan 0x%04x\n", vid);
@@ -842,7 +842,7 @@ int qede_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid) 
		if (vlan->vid == vid)

			break;



	if (!vlan || (vlan->vid != vid)) {

	if (list_entry_is_head(vlan, &edev->vlan_list, list)) {

		DP_VERBOSE(edev, (NETIF_MSG_IFUP | NETIF_MSG_IFDOWN),

			   "Vlan isn't configured\n");

		goto out;