Commit 790437bb authored by Dan Carpenter's avatar Dan Carpenter Committed by Stephen Boyd
Browse files

clk: stm32: Fix a signedness issue in clk_stm32_composite_determine_rate() 



The divider_ro_round_rate() function could potentially return -EINVAL on
error but the error handling doesn't work because "rate" is unsigned.
It should be a type long.

Fixes: 06ed0fc0 ("clk: stm32: composite: Switch to determine_rate")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/d9a78453-9b40-48c1-830e-00751ba3ecb8@kili.mountain


Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent ceb87a36

drivers/clk/stm32/clk-stm32-core.c

+1 −1
Original line number Diff line number Diff line
@@ -431,7 +431,7 @@ static int clk_stm32_composite_determine_rate(struct clk_hw *hw, 
{

	struct clk_stm32_composite *composite = to_clk_stm32_composite(hw);

	const struct stm32_div_cfg *divider;

	unsigned long rate;

	long rate;



	if (composite->div_id == NO_STM32_DIV)

		return 0;