Commit 79025e72 authored by Jens Axboe's avatar Jens Axboe Committed by Jason A. Donenfeld
Browse files

random: wire up fops->splice_{read,write}_iter() 



Now that random/urandom is using {read,write}_iter, we can wire it up to
using the generic splice handlers.

Fixes: 36e2c742 ("fs: don't allow splice read/write without explicit ops")
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
[Jason: added the splice_write path. Note that sendfile() and such still
 does not work for read, though it does for write, because of a file
 type restriction in splice_direct_to_actor(), which I'll address
 separately.]
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
parent 22b0a222

drivers/char/random.c

+4 −0
Original line number Diff line number Diff line
@@ -1412,6 +1412,8 @@ const struct file_operations random_fops = { 
	.compat_ioctl = compat_ptr_ioctl,

	.fasync = random_fasync,

	.llseek = noop_llseek,

	.splice_read = generic_file_splice_read,

	.splice_write = iter_file_splice_write,

};



const struct file_operations urandom_fops = {
@@ -1421,6 +1423,8 @@ const struct file_operations urandom_fops = { 
	.compat_ioctl = compat_ptr_ioctl,

	.fasync = random_fasync,

	.llseek = noop_llseek,

	.splice_read = generic_file_splice_read,

	.splice_write = iter_file_splice_write,

};