Commit 78f7a3fd authored by Eric Biggers's avatar Eric Biggers Committed by Kees Cook
Browse files

randstruct: disable Clang 15 support 

The randstruct support released in Clang 15 is unsafe to use due to a
bug that can cause miscompilations: "-frandomize-layout-seed
inconsistently randomizes all-function-pointers structs"
(https://github.com/llvm/llvm-project/issues/60349

).  It has been fixed
on the Clang 16 release branch, so add a Clang version check.

Fixes: 035f7f87 ("randstruct: Enable Clang support")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Acked-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarBill Wendling <morbo@google.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230208065133.220589-1-ebiggers@kernel.org
parent 04ffde13

security/Kconfig.hardening

+3 −0
Original line number Diff line number Diff line
@@ -281,6 +281,9 @@ endmenu 


config CC_HAS_RANDSTRUCT

	def_bool $(cc-option,-frandomize-layout-seed-file=/dev/null)

	# Randstruct was first added in Clang 15, but it isn't safe to use until

	# Clang 16 due to https://github.com/llvm/llvm-project/issues/60349

	depends on !CC_IS_CLANG || CLANG_VERSION >= 160000



choice

	prompt "Randomize layout of sensitive kernel structures"