Commit 78db2985 authored by Vasant Hegde's avatar Vasant Hegde Committed by Joerg Roedel
Browse files

iommu/amd: Remove extern from function prototypes 



The kernel coding style does not require 'extern' in function prototypes.
Hence remove them from header file.

No functional change intended.

Suggested-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: default avatarVasant Hegde <vasant.hegde@amd.com>
Reviewed-by: default avatarJerry Snitselaar <jsnitsel@redhat.com>
Link: https://lore.kernel.org/r/20230609090631.6052-2-vasant.hegde@amd.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent d18f4ee2

drivers/iommu/amd/amd_iommu.h

+45 −47
Original line number Diff line number Diff line
@@ -11,14 +11,14 @@ 


#include "amd_iommu_types.h"



extern irqreturn_t amd_iommu_int_thread(int irq, void *data);

extern irqreturn_t amd_iommu_int_handler(int irq, void *data);

extern void amd_iommu_apply_erratum_63(struct amd_iommu *iommu, u16 devid);

extern void amd_iommu_restart_event_logging(struct amd_iommu *iommu);

extern int amd_iommu_init_devices(void);

extern void amd_iommu_uninit_devices(void);

extern void amd_iommu_init_notifier(void);

extern void amd_iommu_set_rlookup_table(struct amd_iommu *iommu, u16 devid);

irqreturn_t amd_iommu_int_thread(int irq, void *data);

irqreturn_t amd_iommu_int_handler(int irq, void *data);

void amd_iommu_apply_erratum_63(struct amd_iommu *iommu, u16 devid);

void amd_iommu_restart_event_logging(struct amd_iommu *iommu);

int amd_iommu_init_devices(void);

void amd_iommu_uninit_devices(void);

void amd_iommu_init_notifier(void);

void amd_iommu_set_rlookup_table(struct amd_iommu *iommu, u16 devid);



#ifdef CONFIG_AMD_IOMMU_DEBUGFS

void amd_iommu_debugfs_setup(struct amd_iommu *iommu);
@@ -27,11 +27,11 @@ static inline void amd_iommu_debugfs_setup(struct amd_iommu *iommu) {} 
#endif



/* Needed for interrupt remapping */

extern int amd_iommu_prepare(void);

extern int amd_iommu_enable(void);

extern void amd_iommu_disable(void);

extern int amd_iommu_reenable(int);

extern int amd_iommu_enable_faulting(void);

int amd_iommu_prepare(void);

int amd_iommu_enable(void);

void amd_iommu_disable(void);

int amd_iommu_reenable(int mode);

int amd_iommu_enable_faulting(void);

extern int amd_iommu_guest_ir;

extern enum io_pgtable_fmt amd_iommu_pgtable;

extern int amd_iommu_gpt_level;
@@ -39,33 +39,32 @@ extern int amd_iommu_gpt_level; 
/* IOMMUv2 specific functions */

struct iommu_domain;



extern bool amd_iommu_v2_supported(void);

extern struct amd_iommu *get_amd_iommu(unsigned int idx);

extern u8 amd_iommu_pc_get_max_banks(unsigned int idx);

extern bool amd_iommu_pc_supported(void);

extern u8 amd_iommu_pc_get_max_counters(unsigned int idx);

extern int amd_iommu_pc_get_reg(struct amd_iommu *iommu, u8 bank, u8 cntr,

bool amd_iommu_v2_supported(void);

struct amd_iommu *get_amd_iommu(unsigned int idx);

u8 amd_iommu_pc_get_max_banks(unsigned int idx);

bool amd_iommu_pc_supported(void);

u8 amd_iommu_pc_get_max_counters(unsigned int idx);

int amd_iommu_pc_get_reg(struct amd_iommu *iommu, u8 bank, u8 cntr,

			 u8 fxn, u64 *value);

extern int amd_iommu_pc_set_reg(struct amd_iommu *iommu, u8 bank, u8 cntr,

int amd_iommu_pc_set_reg(struct amd_iommu *iommu, u8 bank, u8 cntr,

			 u8 fxn, u64 *value);



extern int amd_iommu_register_ppr_notifier(struct notifier_block *nb);

extern int amd_iommu_unregister_ppr_notifier(struct notifier_block *nb);

extern void amd_iommu_domain_direct_map(struct iommu_domain *dom);

extern int amd_iommu_domain_enable_v2(struct iommu_domain *dom, int pasids);

extern int amd_iommu_flush_page(struct iommu_domain *dom, u32 pasid,

				u64 address);

extern void amd_iommu_update_and_flush_device_table(struct protection_domain *domain);

extern void amd_iommu_domain_update(struct protection_domain *domain);

extern void amd_iommu_domain_flush_complete(struct protection_domain *domain);

extern void amd_iommu_domain_flush_tlb_pde(struct protection_domain *domain);

extern int amd_iommu_flush_tlb(struct iommu_domain *dom, u32 pasid);

extern int amd_iommu_domain_set_gcr3(struct iommu_domain *dom, u32 pasid,

int amd_iommu_register_ppr_notifier(struct notifier_block *nb);

int amd_iommu_unregister_ppr_notifier(struct notifier_block *nb);

void amd_iommu_domain_direct_map(struct iommu_domain *dom);

int amd_iommu_domain_enable_v2(struct iommu_domain *dom, int pasids);

int amd_iommu_flush_page(struct iommu_domain *dom, u32 pasid, u64 address);

void amd_iommu_update_and_flush_device_table(struct protection_domain *domain);

void amd_iommu_domain_update(struct protection_domain *domain);

void amd_iommu_domain_flush_complete(struct protection_domain *domain);

void amd_iommu_domain_flush_tlb_pde(struct protection_domain *domain);

int amd_iommu_flush_tlb(struct iommu_domain *dom, u32 pasid);

int amd_iommu_domain_set_gcr3(struct iommu_domain *dom, u32 pasid,

			      unsigned long cr3);

extern int amd_iommu_domain_clear_gcr3(struct iommu_domain *dom, u32 pasid);

int amd_iommu_domain_clear_gcr3(struct iommu_domain *dom, u32 pasid);



#ifdef CONFIG_IRQ_REMAP

extern int amd_iommu_create_irq_domain(struct amd_iommu *iommu);

int amd_iommu_create_irq_domain(struct amd_iommu *iommu);

#else

static inline int amd_iommu_create_irq_domain(struct amd_iommu *iommu)

{
@@ -77,7 +76,7 @@ static inline int amd_iommu_create_irq_domain(struct amd_iommu *iommu) 
#define PPR_INVALID			0x1

#define PPR_FAILURE			0xf



extern int amd_iommu_complete_ppr(struct pci_dev *pdev, u32 pasid,

int amd_iommu_complete_ppr(struct pci_dev *pdev, u32 pasid,

			   int status, int tag);



static inline bool is_rd890_iommu(struct pci_dev *pdev)
@@ -131,10 +130,9 @@ static inline void *alloc_pgtable_page(int nid, gfp_t gfp) 
	return page ? page_address(page) : NULL;

}



extern bool translation_pre_enabled(struct amd_iommu *iommu);

extern bool amd_iommu_is_attach_deferred(struct device *dev);

extern int __init add_special_device(u8 type, u8 id, u32 *devid,

				     bool cmd_line);

bool translation_pre_enabled(struct amd_iommu *iommu);

bool amd_iommu_is_attach_deferred(struct device *dev);

int __init add_special_device(u8 type, u8 id, u32 *devid, bool cmd_line);



#ifdef CONFIG_DMI

void amd_iommu_apply_ivrs_quirks(void);
@@ -142,9 +140,9 @@ void amd_iommu_apply_ivrs_quirks(void); 
static inline void amd_iommu_apply_ivrs_quirks(void) { }

#endif



extern void amd_iommu_domain_set_pgtable(struct protection_domain *domain,

void amd_iommu_domain_set_pgtable(struct protection_domain *domain,

				  u64 *root, int mode);

extern struct dev_table_entry *get_dev_table(struct amd_iommu *iommu);

struct dev_table_entry *get_dev_table(struct amd_iommu *iommu);



extern u64 amd_iommu_efr;

extern u64 amd_iommu_efr2;

drivers/iommu/amd/amd_iommu_types.h

+1 −1
Original line number Diff line number Diff line
@@ -886,7 +886,7 @@ extern int amd_iommu_max_glx_val; 
 * This function flushes all internal caches of

 * the IOMMU used by this driver.

 */

extern void iommu_flush_all_caches(struct amd_iommu *iommu);

void iommu_flush_all_caches(struct amd_iommu *iommu);



static inline int get_ioapic_devid(int id)

{