Commit 78ccef91 authored by Mike Snitzer's avatar Mike Snitzer
Browse files

dm: do not return early from dm_io_complete if BLK_STS_AGAIN without polling



Commit 52919840 ("dm: fix bio polling to handle possibile
BLK_STS_AGAIN") inadvertently introduced an early return from
dm_io_complete() without first queueing the bio to DM if BLK_STS_AGAIN
occurs and bio-polling is _not_ being used.

Fix this by only returning early from dm_io_complete() if the bio has
first been properly queued to DM. Otherwise, the bio will never finish
via bio_endio.

Fixes: 52919840 ("dm: fix bio polling to handle possibile BLK_STS_AGAIN")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMike Snitzer <snitzer@kernel.org>
parent 9ae6e8b1
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -939,8 +939,10 @@ static void dm_io_complete(struct dm_io *io)
			if (io_error == BLK_STS_AGAIN) {
				/* io_uring doesn't handle BLK_STS_AGAIN (yet) */
				queue_io(md, bio);
				return;
			}
		}
		if (io_error == BLK_STS_DM_REQUEUE)
			return;
	}