Commit 78b874b7 authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: make 1-bit bit-fields unsigned int 

The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
which is not recommended as the representation is an implementation defined
behaviour.  Fix this by making the bit-fields unsigned ints.

Link: https://lore.kernel.org/r/20200428102013.1040598-1-colin.king@canonical.com


Fixes: cbb01c2f ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 20a66f2b

drivers/scsi/qla2xxx/qla_def.h

+2 −2
Original line number Diff line number Diff line
@@ -4248,8 +4248,8 @@ struct qla_hw_data { 
	int		fw_dump_reading;

	void		*mpi_fw_dump;

	u32		mpi_fw_dump_len;

	int		mpi_fw_dump_reading:1;

	int		mpi_fw_dumped:1;

	unsigned int	mpi_fw_dump_reading:1;

	unsigned int	mpi_fw_dumped:1;

	int		prev_minidump_failed;

	dma_addr_t	eft_dma;

	void		*eft;