Commit 78b23814 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Alex Williamson
Browse files

vfio/iommu_type1: Use struct_size() for kzalloc() 



Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows
that, in the worst scenario, could lead to heap overflows.

This code was detected with the help of Coccinelle and, audited and
fixed manually.

Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Message-Id: <20210513230155.GA217517@embeddedor>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 2a55ca37

drivers/vfio/vfio_iommu_type1.c

+1 −1
Original line number Diff line number Diff line
@@ -2795,7 +2795,7 @@ static int vfio_iommu_iova_build_caps(struct vfio_iommu *iommu, 
		return 0;

	}



	size = sizeof(*cap_iovas) + (iovas * sizeof(*cap_iovas->iova_ranges));

	size = struct_size(cap_iovas, iova_ranges, iovas);



	cap_iovas = kzalloc(size, GFP_KERNEL);

	if (!cap_iovas)