Commit 78aabcb3 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpuidle: teo: Avoid unnecessary variable assignments 



Notice that it is not necessary to assign tick_intercept_sum in every
iteration of the first loop over idle states in teo_select(), because
the intercept_sum value does not change after the assignment in a
given iteration of the loop, so its value after the last iteration of
the loop can be used for computing the tick_intercept_sum value
directly.

Modify the code accordingly.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5484e31b

drivers/cpuidle/governors/teo.c

+2 −3
Original line number Diff line number Diff line
@@ -450,8 +450,6 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, 
		hit_sum += prev_bin->hits;

		recent_sum += prev_bin->recent;



		tick_intercept_sum = intercept_sum;



		if (dev->states_usage[i].disable)

			continue;
@@ -484,7 +482,8 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev, 
		goto end;

	}



	tick_intercept_sum += cpu_data->state_bins[drv->state_count-1].intercepts;

	tick_intercept_sum = intercept_sum +

			cpu_data->state_bins[drv->state_count-1].intercepts;



	/*

	 * If the sum of the intercepts metric for all of the idle states