Commit 78a9ea43 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Jakub Kicinski
Browse files

net: dsa: sja1105: fix memory leak in sja1105_setup_devlink_regions() 



When dsa_devlink_region_create failed in sja1105_setup_devlink_regions(),
priv->regions is not released.

Fixes: bf425b82 ("net: dsa: sja1105: expose static config as devlink region")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20221205012132.2110979-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e40febfb

drivers/net/dsa/sja1105/sja1105_devlink.c

+2 −0
Original line number Diff line number Diff line
@@ -95,6 +95,8 @@ static int sja1105_setup_devlink_regions(struct dsa_switch *ds) 
		if (IS_ERR(region)) {

			while (--i >= 0)

				dsa_devlink_region_destroy(priv->regions[i]);



			kfree(priv->regions);

			return PTR_ERR(region);

		}