Commit 78a03343 authored by Chris Wilson's avatar Chris Wilson Committed by Matt Roper
Browse files

drm/i915/gt: Cleanup partial engine discovery failures 



If we abort driver initialisation in the middle of gt/engine discovery,
some engines will be fully setup and some not. Those incompletely setup
engines only have 'engine->release == NULL' and so will leak any of the
common objects allocated.

v2:
 - Drop the destroy_pinned_context() helper for now.  It's not really
   worth it with just a single callsite at the moment.  (Janusz)

Signed-off-by: default avatarChris Wilson <chris.p.wilson@intel.com>
Cc: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Reviewed-by: default avatarJanusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220915232654.3283095-2-matthew.d.roper@intel.com
parent 8adc7188

drivers/gpu/drm/i915/gt/intel_engine_cs.c

+6 −1
Original line number Diff line number Diff line
@@ -1274,8 +1274,13 @@ int intel_engines_init(struct intel_gt *gt) 
			return err;



		err = setup(engine);

		if (err)

		if (err) {

			intel_engine_cleanup_common(engine);

			return err;

		}



		/* The backend should now be responsible for cleanup */

		GEM_BUG_ON(engine->release == NULL);



		err = engine_init_common(engine);

		if (err)