Commit 787dbea1 authored by Ben Dooks's avatar Ben Dooks Committed by Andrew Morton
Browse files

profile: setup_profiling_timer() is moslty not implemented 

The setup_profiling_timer() is mostly un-implemented by many
architectures.  In many places it isn't guarded by CONFIG_PROFILE which is
needed for it to be used.  Make it a weak symbol in kernel/profile.c and
remove the 'return -EINVAL' implementations from the kenrel.

There are a couple of architectures which do return 0 from the
setup_profiling_timer() function but they don't seem to do anything else
with it.  To keep the /proc compatibility for now, leave these for a
future update or removal.

On ARM, this fixes the following sparse warning:
arch/arm/kernel/smp.c:793:5: warning: symbol 'setup_profiling_timer' was not declared. Should it be static?

Link: https://lkml.kernel.org/r/20220721195509.418205-1-ben-linux@fluff.org


Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 45ee6d1e

arch/alpha/kernel/smp.c

+0 −6
Original line number Diff line number Diff line
@@ -497,12 +497,6 @@ smp_cpus_done(unsigned int max_cpus) 
	       ((bogosum + 2500) / (5000/HZ)) % 100);

}



int

setup_profiling_timer(unsigned int multiplier)

{

	return -EINVAL;

}



static void

send_ipi_message(const struct cpumask *to_whom, enum ipi_message_type operation)

{

arch/arc/kernel/smp.c

+0 −8
Original line number Diff line number Diff line
@@ -232,14 +232,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) 
	return 0;

}



/*

 * not supported here

 */

int setup_profiling_timer(unsigned int multiplier)

{

	return -EINVAL;

}



/*****************************************************************************/

/*              Inter Processor Interrupt Handling                           */

/*****************************************************************************/

arch/arm/kernel/smp.c

+0 −8
Original line number Diff line number Diff line
@@ -787,14 +787,6 @@ void panic_smp_self_stop(void) 
		cpu_relax();

}



/*

 * not supported here

 */

int setup_profiling_timer(unsigned int multiplier)

{

	return -EINVAL;

}



#ifdef CONFIG_CPU_FREQ



static DEFINE_PER_CPU(unsigned long, l_p_j_ref);

arch/arm64/kernel/smp.c

+0 −8
Original line number Diff line number Diff line
@@ -1078,14 +1078,6 @@ bool smp_crash_stop_failed(void) 
}

#endif



/*

 * not supported here

 */

int setup_profiling_timer(unsigned int multiplier)

{

	return -EINVAL;

}



static bool have_cpu_die(void)

{

#ifdef CONFIG_HOTPLUG_CPU

arch/csky/kernel/smp.c

+0 −5
Original line number Diff line number Diff line
@@ -243,11 +243,6 @@ void __init smp_cpus_done(unsigned int max_cpus) 
{

}



int setup_profiling_timer(unsigned int multiplier)

{

	return -EINVAL;

}



void csky_start_secondary(void)

{

	struct mm_struct *mm = &init_mm;