Commit 785c0099 authored by Yang Li's avatar Yang Li Committed by Hans de Goede
Browse files

platform/x86/amd/pmf: Fix unsigned comparison with less than zero 



The return value from the call to amd_pmf_get_pprof_modes() is int.
However, the return value is being assigned to an unsigned char
variable 'mode', so making 'mode' an int.

silence the warning:
./drivers/platform/x86/amd/pmf/sps.c:183:5-9: WARNING: Unsigned expression compared with zero: mode < 0

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5995


Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230727014315.51375-1-yang.lee@linux.alibaba.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent c2173375

drivers/platform/x86/amd/pmf/sps.c

+2 −1
Original line number Diff line number Diff line
@@ -176,7 +176,8 @@ int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf) 


int amd_pmf_power_slider_update_event(struct amd_pmf_dev *dev)

{

	u8 mode, flag = 0;

	u8 flag = 0;

	int mode;

	int src;



	mode = amd_pmf_get_pprof_modes(dev);