Commit 784a0995 authored by Lv Ruyi's avatar Lv Ruyi Committed by Theodore Ts'o
Browse files

ext4: remove unnecessary conditionals 



iput() has already handled null and non-null parameter, so it is no
need to use if().

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarLv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220411032337.2517465-1-lv.ruyi@zte.com.cn


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent af2b3275

fs/ext4/fast_commit.c

+1 −2
Original line number Diff line number Diff line
@@ -1659,7 +1659,6 @@ static int ext4_fc_replay_create(struct super_block *sb, struct ext4_fc_tl *tl, 
	set_nlink(inode, 1);

	ext4_mark_inode_dirty(NULL, inode);

out:

	if (inode)

	iput(inode);

	return ret;

}

fs/ext4/namei.c

+1 −2
Original line number Diff line number Diff line
@@ -3363,7 +3363,6 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir, 
	err = ext4_add_nondir(handle, dentry, &inode);

	if (handle)

		ext4_journal_stop(handle);

	if (inode)

	iput(inode);

	goto out_free_encrypted_link;