Commit 782cd939 authored by Li Jun's avatar Li Jun Committed by Chanwoo Choi
Browse files

extcon: ptn5150: Add queue work sync before driver release 



Add device managed action to sync pending queue work, otherwise
the queued work may run after the work is destroyed.

Fixes: 4ed754de ("extcon: Add support for ptn5150 extcon driver")
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarLi Jun <jun.li@nxp.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent a84df1c7

drivers/extcon/extcon-ptn5150.c

+11 −0
Original line number Diff line number Diff line
@@ -194,6 +194,13 @@ static int ptn5150_init_dev_type(struct ptn5150_info *info) 
	return 0;

}



static void ptn5150_work_sync_and_put(void *data)

{

	struct ptn5150_info *info = data;



	cancel_work_sync(&info->irq_work);

}



static int ptn5150_i2c_probe(struct i2c_client *i2c)

{

	struct device *dev = &i2c->dev;
@@ -284,6 +291,10 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c) 
	if (ret)

		return -EINVAL;



	ret = devm_add_action_or_reset(dev, ptn5150_work_sync_and_put, info);

	if (ret)

		return ret;



	/*

	 * Update current extcon state if for example OTG connection was there

	 * before the probe