Commit 781b9ae4 authored by Mukesh Sisodiya's avatar Mukesh Sisodiya Committed by Luca Coelho
Browse files

iwlwifi: correction of group-id once sending REPLY_ERROR 



Once sending the REPLY_ERROR group ID is not set and this lead to
get it set to wrong value LONG_GROUP later in default handling

Fix this by checking the REPLY_ERROR and avoid changing the Group ID

Signed-off-by: default avatarMukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20210210142629.82578caaea84.I0ca9cfdd4e656d2e88ee7696dd6baf4267e7cb52@changeid


Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 1205d7f7

drivers/net/wireless/intel/iwlwifi/iwl-trans.c

+5 −2
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
#include "iwl-fh.h"

#include "queue/tx.h"

#include <linux/dmapool.h>

#include "fw/api/commands.h"



struct iwl_trans *iwl_trans_alloc(unsigned int priv_size,

				  struct device *dev,
@@ -161,8 +162,10 @@ int iwl_trans_send_cmd(struct iwl_trans *trans, struct iwl_host_cmd *cmd) 
	if (!(cmd->flags & CMD_ASYNC))

		lock_map_acquire_read(&trans->sync_cmd_lockdep_map);



	if (trans->wide_cmd_header && !iwl_cmd_groupid(cmd->id))

	if (trans->wide_cmd_header && !iwl_cmd_groupid(cmd->id)) {

		if (cmd->id != REPLY_ERROR)

			cmd->id = DEF_ID(cmd->id);

	}



	ret = iwl_trans_txq_send_hcmd(trans, cmd);