Commit 77ba9119 authored by Gregory Herrero's avatar Gregory Herrero Committed by Felipe Balbi
Browse files

usb: dwc2: gadget: don't modify pullup state in host mode 



Modifying the pullup state during host mode trig a new enumeration
of attached device. Thus, avoid modifying pullup in host mode.

Signed-off-by: default avatarGregory Herrero <gregory.herrero@intel.com>
Signed-off-by: default avatarMian Yousaf Kaukab <yousaf.kaukab@intel.com>
Tested-by: default avatarRobert Baldyga <r.baldyga@samsung.com>
Tested-by: default avatarDinh Nguyen <dinguyen@opensource.altera.com>
Tested-by: default avatarJohn Youn <johnyoun@synopsys.com>
Acked-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 857512d0

drivers/usb/dwc2/gadget.c

+8 −1
Original line number Diff line number Diff line
@@ -3170,7 +3170,14 @@ static int dwc2_hsotg_pullup(struct usb_gadget *gadget, int is_on) 
	struct dwc2_hsotg *hsotg = to_hsotg(gadget);

	unsigned long flags = 0;



	dev_dbg(hsotg->dev, "%s: is_on: %d\n", __func__, is_on);

	dev_dbg(hsotg->dev, "%s: is_on: %d op_state: %d\n", __func__, is_on,

			hsotg->op_state);



	/* Don't modify pullup state while in host mode */

	if (hsotg->op_state != OTG_STATE_B_PERIPHERAL) {

		hsotg->enabled = is_on;

		return 0;

	}



	mutex_lock(&hsotg->init_mutex);

	spin_lock_irqsave(&hsotg->lock, flags);