Commit 77337ede authored by Jules Irenge's avatar Jules Irenge Committed by Linus Torvalds
Browse files

mm/compaction: add missing annotation for compact_lock_irqsave 



Sparse reports a warning at compact_lock_irqsave()

warning: context imbalance in compact_lock_irqsave() - wrong count at exit

The root cause is the missing annotation at compact_lock_irqsave()
Add the missing __acquires(lock) annotation.

Signed-off-by: default avatarJules Irenge <jbi.octave@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200214204741.94112-6-jbi.octave@gmail.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bb8b93b5

mm/compaction.c

+1 −0
Original line number Diff line number Diff line
@@ -481,6 +481,7 @@ static bool test_and_set_skip(struct compact_control *cc, struct page *page, 
 */

static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags,

						struct compact_control *cc)

	__acquires(lock)

{

	/* Track if the lock is contended in async mode */

	if (cc->mode == MIGRATE_ASYNC && !cc->contended) {