Unverified Commit 76f5aaab authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

ASoC: soc-ac97: Return correct error codes 



With the switching to dev_err_probe(), during the conversion
of GPIO calls, the return code is passed is a paratemer to it.
At the same time a copy'n'paste mistake was made, so the wrong
variable has been taken for the error reporting. Fix this.

Fixes: 3ee0d39c ("ASoC: soc-ac97: Convert to agnostic GPIO API")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230215132343.35547-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fdff966b

sound/soc/soc-ac97.c

+2 −2
Original line number Diff line number Diff line
@@ -336,12 +336,12 @@ static int snd_soc_ac97_parse_pinctl(struct device *dev, 


	cfg->sdata_gpio = devm_gpiod_get_index(dev, "ac97", 1, GPIOD_ASIS);

	if (IS_ERR(cfg->sdata_gpio))

		return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-sdata gpio\n");

		return dev_err_probe(dev, PTR_ERR(cfg->sdata_gpio), "Can't find ac97-sdata gpio\n");

	gpiod_set_consumer_name(cfg->sdata_gpio, "AC97 link sdata");



	cfg->reset_gpio = devm_gpiod_get_index(dev, "ac97", 2, GPIOD_ASIS);

	if (IS_ERR(cfg->reset_gpio))

		return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-reset gpio\n");

		return dev_err_probe(dev, PTR_ERR(cfg->reset_gpio), "Can't find ac97-reset gpio\n");

	gpiod_set_consumer_name(cfg->reset_gpio, "AC97 link reset");



	return 0;