Commit 76e26e3c authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'drm-fixes-2023-01-27' of git://anongit.freedesktop.org/drm/drm 

Pull drm fixes from Dave Airlie:
 "Fairly small this week as well, i915 has a memory leak fix and some
  minor changes, and amdgpu has some MST fixes, and some other minor
  ones:

  drm:
   - DP MST kref fix
   - fb_helper: check return value

  i915:
   - Fix BSC default context for Meteor Lake
   - Fix selftest-scheduler's modify_type
   - memory leak fix

  amdgpu:
   - GC11.x fixes
   - SMU13.0.0 fix
   - Freesync video fix
   - DP MST fixes
   - build fix"

* tag 'drm-fixes-2023-01-27' of git://anongit.freedesktop.org/drm/drm:
  amdgpu: fix build on non-DCN platforms.
  drm/amd/display: Fix timing not changning when freesync video is enabled
  drm/display/dp_mst: Correct the kref of port.
  drm/amdgpu/display/mst: update mst_mgr relevant variable when long HPD
  drm/amdgpu/display/mst: limit payload to be updated one by one
  drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments
  drm/amdgpu: declare firmware for new MES 11.0.4
  drm/amdgpu: enable imu firmware for GC 11.0.4
  drm/amd/pm: add missing AllowIHInterrupt message mapping for SMU13.0.0
  drm/amdgpu: remove unconditional trap enable on add gfx11 queues
  drm/fb-helper: Use a per-driver FB deferred I/O handler
  drm/fb-helper: Check fb_deferred_io_init() return value
  drm/i915/selftest: fix intel_selftest_modify_policy argument types
  drm/i915/mtl: Fix bcs default context
  drm/i915: Fix a memory leak with reused mmap_offset
  drm/drm_vma_manager: Add drm_vma_node_allow_once()
parents 04ad927c d23db898

drivers/gpu/drm/amd/amdgpu/imu_v11_0.c

+1 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_0_imu.bin"); 
MODULE_FIRMWARE("amdgpu/gc_11_0_1_imu.bin");

MODULE_FIRMWARE("amdgpu/gc_11_0_2_imu.bin");

MODULE_FIRMWARE("amdgpu/gc_11_0_3_imu.bin");

MODULE_FIRMWARE("amdgpu/gc_11_0_4_imu.bin");



static int imu_v11_0_init_microcode(struct amdgpu_device *adev)

{

drivers/gpu/drm/amd/amdgpu/mes_v11_0.c

+2 −1
Original line number Diff line number Diff line
@@ -40,6 +40,8 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes.bin"); 
MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes1.bin");

MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes.bin");

MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes1.bin");

MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes.bin");

MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes1.bin");



static int mes_v11_0_hw_fini(void *handle);

static int mes_v11_0_kiq_hw_init(struct amdgpu_device *adev);
@@ -196,7 +198,6 @@ static int mes_v11_0_add_hw_queue(struct amdgpu_mes *mes, 
	mes_add_queue_pkt.trap_handler_addr = input->tba_addr;

	mes_add_queue_pkt.tma_addr = input->tma_addr;

	mes_add_queue_pkt.is_kfd_process = input->is_kfd_process;

	mes_add_queue_pkt.trap_en = 1;



	/* For KFD, gds_size is re-used for queue size (needed in MES for AQL queues) */

	mes_add_queue_pkt.is_aql_queue = input->is_aql_queue;

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+31 −0
Original line number Diff line number Diff line
@@ -8881,6 +8881,13 @@ static int dm_update_crtc_state(struct amdgpu_display_manager *dm, 
		if (!dm_old_crtc_state->stream)

			goto skip_modeset;



		/* Unset freesync video if it was active before */

		if (dm_old_crtc_state->freesync_config.state == VRR_STATE_ACTIVE_FIXED) {

			dm_new_crtc_state->freesync_config.state = VRR_STATE_INACTIVE;

			dm_new_crtc_state->freesync_config.fixed_refresh_in_uhz = 0;

		}



		/* Now check if we should set freesync video mode */

		if (amdgpu_freesync_vid_mode && dm_new_crtc_state->stream &&

		    is_timing_unchanged_for_freesync(new_crtc_state,

						     old_crtc_state)) {
@@ -9497,6 +9504,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev, 
	bool lock_and_validation_needed = false;

	struct dm_crtc_state *dm_old_crtc_state, *dm_new_crtc_state;

#if defined(CONFIG_DRM_AMD_DC_DCN)

	struct drm_dp_mst_topology_mgr *mgr;

	struct drm_dp_mst_topology_state *mst_state;

	struct dsc_mst_fairness_vars vars[MAX_PIPES];

#endif
@@ -9745,6 +9754,28 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev, 
		lock_and_validation_needed = true;

	}



#if defined(CONFIG_DRM_AMD_DC_DCN)

	/* set the slot info for each mst_state based on the link encoding format */

	for_each_new_mst_mgr_in_state(state, mgr, mst_state, i) {

		struct amdgpu_dm_connector *aconnector;

		struct drm_connector *connector;

		struct drm_connector_list_iter iter;

		u8 link_coding_cap;



		drm_connector_list_iter_begin(dev, &iter);

		drm_for_each_connector_iter(connector, &iter) {

			if (connector->index == mst_state->mgr->conn_base_id) {

				aconnector = to_amdgpu_dm_connector(connector);

				link_coding_cap = dc_link_dp_mst_decide_link_encoding_format(aconnector->dc_link);

				drm_dp_mst_update_slots(mst_state, link_coding_cap);



				break;

			}

		}

		drm_connector_list_iter_end(&iter);

	}

#endif



	/**

	 * Streams and planes are reset when there are changes that affect

	 * bandwidth. Anything that affects bandwidth needs to go through

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

+39 −12
Original line number Diff line number Diff line
@@ -120,24 +120,51 @@ enum dc_edid_status dm_helpers_parse_edid_caps( 
}



static void

fill_dc_mst_payload_table_from_drm(struct drm_dp_mst_topology_state *mst_state,

				   struct amdgpu_dm_connector *aconnector,

fill_dc_mst_payload_table_from_drm(struct dc_link *link,

				   bool enable,

				   struct drm_dp_mst_atomic_payload *target_payload,

				   struct dc_dp_mst_stream_allocation_table *table)

{

	struct dc_dp_mst_stream_allocation_table new_table = { 0 };

	struct dc_dp_mst_stream_allocation *sa;

	struct drm_dp_mst_atomic_payload *payload;

	struct link_mst_stream_allocation_table copy_of_link_table =

										link->mst_stream_alloc_table;



	/* Fill payload info*/

	list_for_each_entry(payload, &mst_state->payloads, next) {

		if (payload->delete)

			continue;

	int i;

	int current_hw_table_stream_cnt = copy_of_link_table.stream_count;

	struct link_mst_stream_allocation *dc_alloc;



	/* TODO: refactor to set link->mst_stream_alloc_table directly if possible.*/

	if (enable) {

		dc_alloc =

		&copy_of_link_table.stream_allocations[current_hw_table_stream_cnt];

		dc_alloc->vcp_id = target_payload->vcpi;

		dc_alloc->slot_count = target_payload->time_slots;

	} else {

		for (i = 0; i < copy_of_link_table.stream_count; i++) {

			dc_alloc =

			&copy_of_link_table.stream_allocations[i];



			if (dc_alloc->vcp_id == target_payload->vcpi) {

				dc_alloc->vcp_id = 0;

				dc_alloc->slot_count = 0;

				break;

			}

		}

		ASSERT(i != copy_of_link_table.stream_count);

	}



	/* Fill payload info*/

	for (i = 0; i < MAX_CONTROLLER_NUM; i++) {

		dc_alloc =

			&copy_of_link_table.stream_allocations[i];

		if (dc_alloc->vcp_id > 0 && dc_alloc->slot_count > 0) {

			sa = &new_table.stream_allocations[new_table.stream_count];

		sa->slot_count = payload->time_slots;

		sa->vcp_id = payload->vcpi;

			sa->slot_count = dc_alloc->slot_count;

			sa->vcp_id = dc_alloc->vcp_id;

			new_table.stream_count++;

		}

	}



	/* Overwrite the old table */

	*table = new_table;
@@ -185,7 +212,7 @@ bool dm_helpers_dp_mst_write_payload_allocation_table( 
	 * AUX message. The sequence is slot 1-63 allocated sequence for each

	 * stream. AMD ASIC stream slot allocation should follow the same

	 * sequence. copy DRM MST allocation to dc */

	fill_dc_mst_payload_table_from_drm(mst_state, aconnector, proposed_table);

	fill_dc_mst_payload_table_from_drm(stream->link, enable, payload, proposed_table);



	return true;

}

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c

+0 −5
Original line number Diff line number Diff line
@@ -903,11 +903,6 @@ static int compute_mst_dsc_configs_for_link(struct drm_atomic_state *state, 
	if (IS_ERR(mst_state))

		return PTR_ERR(mst_state);



	mst_state->pbn_div = dm_mst_get_pbn_divider(dc_link);

#if defined(CONFIG_DRM_AMD_DC_DCN)

	drm_dp_mst_update_slots(mst_state, dc_link_dp_mst_decide_link_encoding_format(dc_link));

#endif



	/* Set up params */

	for (i = 0; i < dc_state->stream_count; i++) {

		struct dc_dsc_policy dsc_policy = {0};