Commit 76d54bf2 authored Feb 26, 2023 by Akinobu Mita Committed by Christoph Hellwig Feb 28, 2023

nvme-tcp: don't access released socket during error recovery

While the error recovery work is temporarily failing reconnect attempts,
running the 'nvme list' command causes a kernel NULL pointer dereference
by calling getsockname() with a released socket.

During error recovery work, the nvme tcp socket is released and a new one
created, so it is not safe to access the socket without proper check.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Fixes: 02c57a82 ("nvme-tcp: print actual source IP address through sysfs "address" attr")
Reviewed-by: Martin Belanger <martin.belanger@dell.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 51d24f70

drivers/nvme/host/tcp.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -2489,6 +2489,10 @@ static int nvme_tcp_get_address(struct nvme_ctrl ctrl, char buf, int size)

		len = nvmf_get_address(ctrl, buf, size);

		mutex_lock(&queue->queue_lock);

		if (!test_bit(NVME_TCP_Q_LIVE, &queue->flags))
		goto done;
		ret = kernel_getsockname(queue->sock, (struct sockaddr *)&src_addr);
		if (ret > 0) {
		if (len > 0)
		@@ -2496,6 +2500,8 @@ static int nvme_tcp_get_address(struct nvme_ctrl ctrl, char buf, int size)
		len += scnprintf(buf + len, size - len, "%ssrc_addr=%pISc\n",
		(len) ? "," : "", &src_addr);
		}
		done:
		mutex_unlock(&queue->queue_lock);

		return len;
		}