Commit 769c18b2 authored by Tal Lossos's avatar Tal Lossos Committed by Daniel Borkmann
Browse files

bpf: Change inode_storage's lookup_elem return value from NULL to -EBADF 



bpf_fd_inode_storage_lookup_elem() returned NULL when getting a bad FD,
which caused -ENOENT in bpf_map_copy_value. -EBADF error is better than
-ENOENT for a bad FD behaviour.

The patch was partially contributed by CyberArk Software, Inc.

Fixes: 8ea63684 ("bpf: Implement bpf_local_storage for inodes")
Signed-off-by: default avatarTal Lossos <tallossos@gmail.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarYonghong Song <yhs@fb.com>
Acked-by: default avatarKP Singh <kpsingh@kernel.org>
Link: https://lore.kernel.org/bpf/20210307120948.61414-1-tallossos@gmail.com
parent 350a5c4d

kernel/bpf/bpf_inode_storage.c

+1 −1
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ static void *bpf_fd_inode_storage_lookup_elem(struct bpf_map *map, void *key) 
	fd = *(int *)key;

	f = fget_raw(fd);

	if (!f)

		return NULL;

		return ERR_PTR(-EBADF);



	sdata = inode_storage_lookup(f->f_inode, map, true);

	fput(f);