Commit 7694a7de authored by 蒋家盛's avatar 蒋家盛 Committed by Jason Gunthorpe
Browse files

RDMA/uverbs: Check for null return of kmalloc_array 

Because of the possible failure of the allocation, data might be NULL
pointer and will cause the dereference of the NULL pointer later.
Therefore, it might be better to check it and return -ENOMEM.

Fixes: 6884c6c4 ("RDMA/verbs: Store the write/write_ex uapi entry points in the uverbs_api")
Link: https://lore.kernel.org/r/20211231093315.1917667-1-jiasheng@iscas.ac.cn


Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 4163cb3d

drivers/infiniband/core/uverbs_uapi.c

+3 −0
Original line number Diff line number Diff line
@@ -447,6 +447,9 @@ static int uapi_finalize(struct uverbs_api *uapi) 
	uapi->num_write_ex = max_write_ex + 1;

	data = kmalloc_array(uapi->num_write + uapi->num_write_ex,

			     sizeof(*uapi->write_methods), GFP_KERNEL);

	if (!data)

		return -ENOMEM;



	for (i = 0; i != uapi->num_write + uapi->num_write_ex; i++)

		data[i] = &uapi->notsupp_method;

	uapi->write_methods = data;