Unverified Commit 767ae499 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!7477 firewire: nosy: ensure user_length is taken into account when fetching packet contents 

Merge Pull Request from: @ci-robot 
 
PR sync from: Hongbo Li <lihongbo22@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/BBOU6WXOS2AMSVF6EVGKBO5YGK3VV3QG/ 
 
https://gitee.com/src-openeuler/kernel/issues/I9OZA3 
 
Link:https://gitee.com/openeuler/kernel/pulls/7477

 

Reviewed-by: default avatarLiu YongQiang <liuyongqiang13@huawei.com>
Reviewed-by: default avatarZhang Jianhua <chris.zjh@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
parents f2cc57c8 6e7dac9a

drivers/firewire/nosy.c

+4 −2
Original line number Diff line number Diff line
@@ -161,10 +161,12 @@ packet_buffer_get(struct client *client, char __user *data, size_t user_length) 
	if (atomic_read(&buffer->size) == 0)

		return -ENODEV;



	/* FIXME: Check length <= user_length. */

	length = buffer->head->length;



	if (length > user_length)

		return 0;



	end = buffer->data + buffer->capacity;

	length = buffer->head->length;



	if (&buffer->head->data[length] < end) {

		if (copy_to_user(data, buffer->head->data, length))