Commit 7605c43d authored by David Lamparter's avatar David Lamparter Committed by Jens Axboe
Browse files

io_uring: remove MSG_NOSIGNAL from recvmsg 



MSG_NOSIGNAL is not applicable for the receiving side, SIGPIPE is
generated when trying to write to a "broken pipe".  AF_PACKET's
packet_recvmsg() does enforce this, giving back EINVAL when MSG_NOSIGNAL
is set - making it unuseable in io_uring's recvmsg.

Remove MSG_NOSIGNAL from io_recvmsg_prep().

Cc: stable@vger.kernel.org # v5.10+
Signed-off-by: default avatarDavid Lamparter <equinox@diac24.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jens Axboe <axboe@kernel.dk>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230224150123.128346-1-equinox@diac24.net


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 977bc873

io_uring/net.c

+1 −1
Original line number Diff line number Diff line
@@ -567,7 +567,7 @@ int io_recvmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) 
	sr->flags = READ_ONCE(sqe->ioprio);

	if (sr->flags & ~(RECVMSG_FLAGS))

		return -EINVAL;

	sr->msg_flags = READ_ONCE(sqe->msg_flags) | MSG_NOSIGNAL;

	sr->msg_flags = READ_ONCE(sqe->msg_flags);

	if (sr->msg_flags & MSG_DONTWAIT)

		req->flags |= REQ_F_NOWAIT;

	if (sr->msg_flags & MSG_ERRQUEUE)