Commit 75fb2af6 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf build-id: Add __perf_session__cache_build_ids function 



Adding __perf_session__cache_build_ids function as an interface for
caching sessions build ids with callback function and its data pointer.

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20201126170026.2619053-20-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0b7b9e83

tools/perf/util/build-id.c

+8 −2
Original line number Diff line number Diff line
@@ -892,7 +892,8 @@ machines__for_each_dso(struct machines *machines, machine__dso_t fn, void *priv) 
	return ret ? -1 : 0;

}



int perf_session__cache_build_ids(struct perf_session *session)

int __perf_session__cache_build_ids(struct perf_session *session,

				    machine__dso_t fn, void *priv)

{

	if (no_buildid_cache)

		return 0;
@@ -900,7 +901,12 @@ int perf_session__cache_build_ids(struct perf_session *session) 
	if (mkdir(buildid_dir, 0755) != 0 && errno != EEXIST)

		return -1;



	return machines__for_each_dso(&session->machines, dso__cache_build_id, NULL) ?  -1 : 0;

	return machines__for_each_dso(&session->machines, fn, priv) ?  -1 : 0;

}



int perf_session__cache_build_ids(struct perf_session *session)

{

	return __perf_session__cache_build_ids(session, dso__cache_build_id, NULL);

}



static bool machine__read_build_ids(struct machine *machine, bool with_hits)

tools/perf/util/build-id.h

+3 −0
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
#define BUILD_ID_SIZE	20

#define SBUILD_ID_SIZE	(BUILD_ID_SIZE * 2 + 1)



#include "machine.h"

#include "tool.h"

#include <linux/types.h>
@@ -46,6 +47,8 @@ bool perf_session__read_build_ids(struct perf_session *session, bool with_hits); 
int perf_session__write_buildid_table(struct perf_session *session,

				      struct feat_fd *fd);

int perf_session__cache_build_ids(struct perf_session *session);

int __perf_session__cache_build_ids(struct perf_session *session,

				    machine__dso_t fn, void *priv);



char *build_id_cache__origname(const char *sbuild_id);

char *build_id_cache__linkname(const char *sbuild_id, char *bf, size_t size);