Commit 75e43355 authored by Jingbo Xu's avatar Jingbo Xu Committed by Gao Xiang
Browse files

erofs: put metabuf in error path in fscache mode 



For tail packing layout, put metabuf when error is encountered.

Fixes: 1ae9470c ("erofs: clean up .read_folio() and .readahead() in fscache mode")
Signed-off-by: default avatarJingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: default avatarJia Zhu <zhujia.zj@bytedance.com>
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20221104054028.52208-2-jefflexu@linux.alibaba.com


Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
parent e5126de1

fs/erofs/fscache.c

+3 −1
Original line number Diff line number Diff line
@@ -287,8 +287,10 @@ static int erofs_fscache_data_read(struct address_space *mapping, 
			return PTR_ERR(src);



		iov_iter_xarray(&iter, READ, &mapping->i_pages, pos, PAGE_SIZE);

		if (copy_to_iter(src + offset, size, &iter) != size)

		if (copy_to_iter(src + offset, size, &iter) != size) {

			erofs_put_metabuf(&buf);

			return -EFAULT;

		}

		iov_iter_zero(PAGE_SIZE - size, &iter);

		erofs_put_metabuf(&buf);

		return PAGE_SIZE;